Skip to content

dataconnect/demo: upgrade dependencies to fix build - #8692

Merged
dconeybe merged 22 commits into
mainfrom
dconeybe/dataconnect/DemoUpgrade
Oct 9, 2026
Merged

dconeybe merged 22 commits into
mainfrom
dconeybe/dataconnect/DemoUpgrade

Conversation

@dconeybe

@dconeybe dconeybe commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

This PR modernizes the Firebase Data Connect demo application and its CI workflow by upgrading Gradle, the Android Gradle Plugin, Kotlin, Java, and all associated dependencies to their latest compatible versions. It also cleans up obsolete build properties, updates code formatting with a newer ktfmt, and ensures smooth execution in GitHub Actions.

Highlights

  • Build Tooling Upgrades: Upgraded Gradle to 9.8.1 (was 8.14.5), Android Gradle Plugin (AGP) to 9.4.1 (was 8.11.1), Spotless to 8.10.4, and Dokka to 2.2.0. Switched to AGP's built-in Kotlin support.
  • Java and JVM Target Upgrade: Upgraded compileOptions and Kotlin jvmTarget to Java 11 (was Java 1.8), and raised compileSdk and targetSdk to 37 (was 36).
  • Dependency Upgrades: Upgraded the Firebase BOM to 35.0.0 (was 33.16.0), Google Services Gradle plugin to 4.5.0, Kotlin coroutines and serialization libraries to 1.11.0, and modern AndroidX libraries (AppCompat, Activity, Lifecycle, Material).
  • Gradle Properties Cleanup: Removed obsolete and deprecated Android Gradle properties, enabled parallel tooling for Gradle 9.4+, and standardized comment syntax from // to #.
  • CI Workflow Improvements: Upgraded the CI JDK to 21 to support Gradle 9.8.1 and AGP 9.4.1, approved necessary npm scripts during firebase-tools setup, and ensured -PdataConnect.demo.firebaseCommand is passed to the Dokka documentation task.
  • Code Formatting: Upgraded ktfmt to 0.65 (was 0.53) and re-applied formatting across Kotlin source files in the demo application.
Changelog
  • dataconnect_demo_app.yml
    • Upgraded CI Java version to 21 (was 17) to support Gradle 9.8.1 and AGP 9.4.1.
    • Approved npm scripts for google-logging-utils, protobufjs, and re2 when installing firebase-tools.
    • Passed -PdataConnect.demo.firebaseCommand to gradle dokkaGeneratePublicationHtml.
  • build.gradle.kts
    • Upgraded AGP to 9.4.1 and switched to built-in Kotlin support.
    • Upgraded Dokka to 2.2.0, Spotless to 8.10.4, and Google Services plugin to 4.5.0.
    • Upgraded Firebase BOM to 35.0.0, Kotlin coroutines and serialization to 1.11.0, and AndroidX libraries.
    • Upgraded Java source and target compatibility, as well as Kotlin jvmTarget, to Java 11.
    • Raised compileSdk and targetSdk to 37.
    • Configured Dokka source sets with configureEach and updated ktfmt version to 0.65.
  • gradle.properties
    • Removed deprecated and obsolete android.* property flags.
    • Standardized inline comments from // to #.
    • Added org.gradle.tooling.parallel=true.
  • gradle-wrapper.properties
    • Upgraded Gradle distribution to 9.8.1 (was 8.14.5).
    • Added retry configuration properties.
  • gradle-wrapper.jar
    • Updated wrapper binary corresponding to Gradle 9.8.1.
  • gradlew
    • Updated Gradle wrapper shell script for Gradle 9.8.1.
  • gradlew.bat
    • Updated Gradle wrapper Windows batch script for Gradle 9.8.1.
  • ListItemsViewModel.kt
    • Re-formatted Kotlin code with ktfmt 0.65.
  • MainViewModel.kt
    • Re-formatted Kotlin code with ktfmt 0.65.
  • MyApplication.kt
    • Re-formatted Kotlin code with ktfmt 0.65.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe
dconeybe marked this pull request as ready for review October 9, 2026 19:46
@dconeybe
dconeybe merged commit ea734d2 into main Oct 9, 2026
174 of 177 checks passed
@dconeybe
dconeybe deleted the dconeybe/dataconnect/DemoUpgrade branch October 9, 2026 20:28
@github-actions github-actions Bot mentioned this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants